Skip to content

Make Rcs and Arcs use pointer comparison for unsized types#155579

Open
Gaming32 wants to merge 1 commit intorust-lang:mainfrom
Gaming32:fix-154998
Open

Make Rcs and Arcs use pointer comparison for unsized types#155579
Gaming32 wants to merge 1 commit intorust-lang:mainfrom
Gaming32:fix-154998

Conversation

@Gaming32
Copy link
Copy Markdown

@Gaming32 Gaming32 commented Apr 21, 2026

Rc and Arcs have an Eq implementation that first attempt to compare the pointers as an optimization. This, however, was not extended to DSTs, which is what this PR fixes.

Fixes #154998.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 21, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 21, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 6 candidates
  • Random selection from Mark-Simulacrum, jhpratt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MarkerEq doesn't specialize on unsized types

3 participants